fix(sdk): remove node-fetch type dependency

icepeng · Dec 17, 2022 · 557a888 · 557a888
1 parent a7ceb7b
commit 557a888
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/.changeset/clever-badgers-cross.md b/.changeset/clever-badgers-cross.md
@@ -0,0 +1,5 @@
+---
+"@mokoko/sdk": patch
+---
+
+remove node-fetch type dependency
diff --git a/packages/sdk/package.json b/packages/sdk/package.json
@@ -25,7 +25,6 @@
     "dev": "tsup src/index.ts --format esm,cjs --watch --dts"
   },
   "devDependencies": {
-    "node-fetch": "^3.3.0",
     "tsup": "^6.5.0",
     "typescript": "4.9.3"
   },

diff --git a/packages/sdk/src/sdk.ts b/packages/sdk/src/sdk.ts
@@ -17,10 +17,6 @@ import { MarketList } from "./models/MarketList";
 import { MarketOption } from "./models/MarketOption";
 import { RequestAuctionItems } from "./models/RequestAuctionItems";
 import { RequestMarketItems } from "./models/RequestMarketItems";
-import type {
-  RequestInit as NodeRequestInit,
-  Response as NodeResponse,
-} from "node-fetch";
 import { Semaphore } from "@shopify/semaphore";
 import { Reporter } from "./reporter";
 
@@ -30,9 +26,7 @@ export interface SdkProps {
   /**
    * Fetch function for isomorphic usage.
    */
-  fetchFn:
-    | ((url: string, init?: RequestInit) => Promise<Response>)
-    | ((url: string, init?: NodeRequestInit) => Promise<NodeResponse>);
+  fetchFn: (url: string, init?: RequestInit) => Promise<Response>;
 
   /**
    * API Key from Lostark Open API Developer Portal.

diff --git a/yarn.lock b/yarn.lock
@@ -360,7 +360,6 @@ __metadata:
   resolution: "@mokoko/sdk@workspace:packages/sdk"
   dependencies:
     "@shopify/semaphore": ^3.0.1
-    node-fetch: ^3.3.0
     tsup: ^6.5.0
     typescript: 4.9.3
   languageName: unknown