Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt Monster, run clippy, attempt to compile. #2

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

boomshroom
Copy link
Contributor

What have you done?

Running cargo test gives the same failures as master, so I consider that a success.

@icefoxen
Copy link
Owner

What have I done? My goodness, what have you done! It looks amazing! I'll try to get some more rigorous tests in there so we can better ensure it works.

@boomshroom
Copy link
Contributor Author

I've mostly been running clippy repeatedly and applying the changes it suggests. I noticed after posting this the test.sh script, but it seems to just spew text to the console. I should probably use diff to track any changes to said output.

@boomshroom
Copy link
Contributor Author

How much am I allowed to change function signatures?

@boomshroom
Copy link
Contributor Author

Hooray! No diff between outputs of test.sh between your original code and my changes!

@icefoxen icefoxen merged commit 7909138 into icefoxen:master Oct 11, 2018
@icefoxen
Copy link
Owner

Awesome, thank you so much! Any chance we can automate those sorts of tests, I wonder...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants