-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive parametric Aeff stage #798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
Note that we have VLVNT parameterisations in https://github.com/icecube/pisa/tree/master/pisa_examples/resources/aeff, and that there are lists of discrete energies and aeffs that need to be interpolated in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just address the interp1d bounds question, then we can merge
Bringing back the parameterized effective area stage that.