Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive parametric Aeff stage #798

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Revive parametric Aeff stage #798

merged 6 commits into from
Aug 12, 2024

Conversation

JanWeldert
Copy link
Contributor

Bringing back the parameterized effective area stage that.

@JanWeldert JanWeldert requested a review from thehrh August 8, 2024 11:12
Copy link
Contributor

@thehrh thehrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
pisa/stages/aeff/param.py Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
@thehrh
Copy link
Contributor

thehrh commented Aug 9, 2024

Note that we have VLVNT parameterisations in https://github.com/icecube/pisa/tree/master/pisa_examples/resources/aeff, and that there are lists of discrete energies and aeffs that need to be interpolated in there.

Copy link
Contributor

@thehrh thehrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just address the interp1d bounds question, then we can merge

pisa/stages/aeff/param.py Show resolved Hide resolved
pisa/stages/aeff/param.py Show resolved Hide resolved
pisa/stages/aeff/param.py Outdated Show resolved Hide resolved
@thehrh thehrh merged commit f739ae4 into icecube:master Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants