Multiply source weights into S/B matrix in one shot #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiplying a CSR matrix row-wise and then summing over rows is ~40x faster than masked assignments to a LIL matrix followed by a row-wise sum. Who knew?
|
That's cool. Could that also be used in the |
|
Quick answer is yes. For |
sathanas31
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiplying a CSR matrix row-wise and then summing over rows is ~40x faster than masked assignments to a LIL matrix followed by a row-wise sum for 100 sources. For 1000 sources, the speedup is ~200x; for 10000, ~1900x (800 ms per gamma point vs 27 minutes). Who knew?