Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for custom function keys #40

Merged
merged 1 commit into from
Aug 2, 2019
Merged

support for custom function keys #40

merged 1 commit into from
Aug 2, 2019

Conversation

Ficik
Copy link
Contributor

@Ficik Ficik commented Jul 29, 2019

I need support for custom buttons (app language toggle in our case).

Right now, unknown key.fun does nothing, emiting the key.func value instead would allow implementers easily create custom interactive button anywhere on the keyboard.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 5.0% when pulling 9cb5335 on Ficik:feature/emit-custom-event into 8f37ccc on icebob:master.

icebob
icebob approved these changes Aug 2, 2019
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@icebob icebob merged commit a50a2e2 into icebob:master Aug 2, 2019
@wallcrosstype wallcrosstype mentioned this pull request Dec 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ficik @coveralls @icebob