Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTMLTextareaElement to input types #31

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Add HTMLTextareaElement to input types #31

merged 1 commit into from
Feb 15, 2019

Conversation

VincentGJ
Copy link

The keyboard doesn't handle the textarea element but only input. By adding 'HTMLTextAreaElement' to the input types of the props, the keyboard can handle the textarea.
I added it in the src and in the dist files.

icebob
icebob approved these changes Feb 15, 2019
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@icebob icebob merged commit ece33e5 into icebob:master Feb 15, 2019
@icebob
Copy link
Owner

icebob commented Feb 15, 2019

Released in 0.3.1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.172% when pulling fa53e7b on VincentGJ:textarea into 78749ab on icebob:master.

@MiniGod MiniGod mentioned this pull request Mar 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentGJ @icebob @coveralls