Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multi): item rule has custom checker will throw error if validate… #290

Merged
merged 4 commits into from
Mar 21, 2022
Merged

fix(multi): item rule has custom checker will throw error if validate… #290

merged 4 commits into from
Mar 21, 2022

Commits on Mar 15, 2022

  1. fix(multi): item rule has custom checker will throw error if validate… 

    … failed

custom checker push errors to fnCustomErrorsX that will be assigned to var errors, not _errors as expected
To avoid a breaking changes, I just keep size of errors before validate and restore it if failed
But I think the logic should be changed
    @0x0a0d
    0x0a0d committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    68fab93 View commit details
    Browse the repository at this point in the history

  2. fix(multi): item rule has custom checker will throw error if validate… 

    … failed

add test
    @0x0a0d
    0x0a0d committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    d0a5c82 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. fix(multi): item rule has custom checker will throw error if validate… 

    … failed

move tests to multi.spec.js
    @0x0a0d
    0x0a0d committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    128d541 View commit details
    Browse the repository at this point in the history

  2. fix(validator): when failed, custom rules should not overwrite value 

    fix minor bug
update test
    @0x0a0d
    0x0a0d committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    a4a7945 View commit details
    Browse the repository at this point in the history