Change ruleSchema type to be the object variant #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there might have been some confusion in my comments in #156 . I had made the comment
I think that is the more appropriate type since it appears to me that even if the
ValidationRuleName
orValidationRuleObject[]
variants are passed in the validator schema, they will be cast to theValidationRuleObject
type when calling the custom function.This PR changes the type in the custom validator signatures to be passed
ValidationRuleObject
rather thanValidationRule
.