Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save codable models #64

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Save codable models #64

wants to merge 6 commits into from

Conversation

APPS2CREATE
Copy link
Contributor

No description provided.

fousa
fousa requested changes Mar 17, 2019
View reviewed changes
Copy link
Collaborator

@fousa fousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voeg je nog info toe aan de README? Ziet er goed uit voor de rest!

@APPS2CREATE
Copy link
Contributor Author

Voeg je nog info toe aan de README? Ziet er goed uit voor de rest!

README toegevoegd, slightly different dan de rest. Omdat ik het ook met een klein voorbeeld wilde tonen zodat het meer relevant was.

@APPS2CREATE APPS2CREATE requested a review from fousa March 17, 2019 20:51
@APPS2CREATE
change class to struct to have a valid example
0fb3d73 
struct has default init - class doesn’t
fousa
fousa requested changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@fousa fousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan het zijn dat de testen falen?

README.md Outdated
@@ -88,6 +88,32 @@ Defaults[.dateValue] = NSDate()
print(Defaults[.dateValue]) // Prints '1996-12-19T16:39:57-08:00'
```

### Codable Defaults
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enkel dit nog in de inhoudstabel toevoegen :)

@HannesVDB
Copy link
Contributor

@AdamsDevelopment, wat is de status van dit?

@APPS2CREATE
Copy link
Contributor Author

@AdamsDevelopment, wat is de status van dit?

Testen falen, een Bool is Codable waardoor er foute interpretatie's ontstaan wanneer je iets saved als codable model of bool. Eens ik een moment tijd vind ga ik dit oplossen. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fousa fousa fousa requested changes

@dgyesbreghs dgyesbreghs Awaiting requested review from dgyesbreghs

@herre herre Awaiting requested review from herre

@HannesVDB HannesVDB Awaiting requested review from HannesVDB

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@APPS2CREATE @HannesVDB @fousa