Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RecurrencePattern.Count, .Interval and WeekDay.Offset nullable to avoid using MinValue as magic number. #667

Merged
merged 5 commits into from
Dec 10, 2024

Test: Add WeekDay-related tests.

6576096
Select commit
Loading
Failed to load commit list.
Merged

Make RecurrencePattern.Count, .Interval and WeekDay.Offset nullable to avoid using MinValue as magic number. #667

Test: Add WeekDay-related tests.
6576096
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 9, 2024 in 1s

63% (target 80%)

Details

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...alization/DataTypes/RecurrencePatternSerializer.cs 50% 4 Missing and 2 partials ⚠️
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 75% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #667   +/-   ##
===================================
- Coverage    63%    63%   -0%     
===================================
  Files        99     99           
  Lines      4592   4594    +2     
  Branches   1086   1085    -1     
===================================
+ Hits       2876   2877    +1     
+ Misses     1261   1258    -3     
- Partials    455    459    +4     
Files with missing lines Coverage Δ
Ical.Net/Constants.cs 44% <ø> (ø)
Ical.Net/DataTypes/RecurrencePattern.cs 74% <100%> (-1%) ⬇️
Ical.Net/DataTypes/WeekDay.cs 74% <100%> (+20%) ⬆️
Ical.Net/Evaluation/TodoEvaluator.cs 47% <100%> (ø)
...l.Net/Serialization/DataTypes/WeekDaySerializer.cs 78% <100%> (ø)
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 71% <75%> (-<1%) ⬇️
...alization/DataTypes/RecurrencePatternSerializer.cs 68% <50%> (-2%) ⬇️