Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurrence: Reproduce and fix issues if BYWEEKNO and INTERVAL are used together #657

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

minichma
Copy link
Collaborator

This PR reproduces and fixes more issues around BYWEEKNO, in particular if used together with INTERVAL and if DTSTART lies in a different year then the week it lies in. E.g. 20100102T000000 is in 2010, but the week number is 53 of 2009. In such cases the lib increments year invervals staring from 2010 rather than from 2009, which is wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…g sites.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…RVAL`.
… and `DTSTART`'s week belongs to a different year than the date's year.
Copy link

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 83% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #657   +/-   ##
===================================
  Coverage    60%    60%           
===================================
  Files       100    100           
  Lines      4657   4661    +4     
  Branches   1106   1109    +3     
===================================
+ Hits       2811   2815    +4     
  Misses     1379   1379           
  Partials    467    467           
Files with missing lines Coverage Δ
Ical.Net/Evaluation/Evaluator.cs 76% <100%> (+4%) ⬆️
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 69% <83%> (-<1%) ⬇️

@minichma minichma marked this pull request as ready for review November 30, 2024 13:09
@minichma minichma requested a review from axunonb November 30, 2024 13:09
Copy link
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good, recurrence quality is increasing! Tnx

@minichma minichma merged commit e40d238 into main Nov 30, 2024
6 of 7 checks passed
@minichma minichma deleted the work/minichma/bugfix/weekno_2016 branch November 30, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants