Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutable state from Evaluators and some related, poorly tested functions #655

Merged
merged 8 commits into from
Nov 30, 2024

Remove unused `TimeZoneEvaluator`.

64c1847
Select commit
Loading
Failed to load commit list.
Merged

Remove mutable state from Evaluators and some related, poorly tested functions #655

Remove unused `TimeZoneEvaluator`.
64c1847
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 29, 2024 in 0s

61% (target 80%)

Details

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Ical.Net/CalendarComponents/Alarm.cs 0% 9 Missing ⚠️
Ical.Net/Evaluation/Evaluator.cs 0% 1 Missing ⚠️
Ical.Net/Evaluation/TodoEvaluator.cs 80% 1 Missing ⚠️

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #655    +/-   ##
====================================
+ Coverage    60%    61%    +1%     
====================================
  Files       100     99     -1     
  Lines      4657   4555   -102     
  Branches   1106   1080    -26     
====================================
- Hits       2811   2787    -24     
+ Misses     1379   1302    -77     
+ Partials    467    466     -1     
Files with missing lines Coverage Δ
Ical.Net/Calendar.cs 63% <ø> (+2%) ⬆️
Ical.Net/CalendarCollection.cs 21% <ø> (+1%) ⬆️
Ical.Net/CalendarComponents/CalendarEvent.cs 71% <100%> (+3%) ⬆️
Ical.Net/CalendarComponents/RecurringComponent.cs 63% <ø> (-<1%) ⬇️
Ical.Net/CalendarComponents/Todo.cs 64% <100%> (ø)
Ical.Net/Evaluation/EventEvaluator.cs 67% <100%> (ø)
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 69% <100%> (-<1%) ⬇️
Ical.Net/Evaluation/RecurrenceUtil.cs 88% <ø> (+2%) ⬆️
Ical.Net/Evaluation/RecurringEvaluator.cs 82% <100%> (-1%) ⬇️
Ical.Net/VTimeZoneInfo.cs 36% <ø> (+1%) ⬆️
... and 3 more