-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connector with intertial pressure #946
Comments
This indeed sounds interesting, although the fast dynamics could become a problem. I scanned the paper. Some initial thoughts before having more time to look into it in more detail:
It would be interesting to figure out why 'our' algebraic loops sometimes do not converge and fix that, rather than try to work around it. |
Try putting the loop breaker in the base class of the resistances, and set the default value for air volumes to be steady-state mass balance (to avoid oscillations).
Separately, the Modelica spec may have to be changed to subtract the nominal value from variables when solving algebraic loops, e.g., for air pressure, one would subtract 1E-5 Pa to avoid pressure differences that are small compared to the variable value. |
If we have a clear (not too many equations and too many different types of equations) example where JModelica fails to solve an algebraic loop, I may try to debug it to see what is really going on on the numerical side. Does anybody have something like that lying around? |
For now, we will look into improvements to the solver and/or other model formulations |
This branch is to evaluate the new fluid modeling approach from
Dirk Zimmer, Daniel Bender and Alexander Pollok presented in
"Robust modeling of directed thermofluid flows in complex networks". Japanese Modelica Conference, 2018. https://elib.dlr.de/120701/1/Modelica2018_Japan_paper_8.pdf
Development branch is
issue946_inertialPressure
The text was updated successfully, but these errors were encountered: