Skip to content
This repository has been archived by the owner on Oct 22, 2020. It is now read-only.

Copy configured values to relevant UMA properties in .spec files #163

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

keithc-ca
Copy link
Member

@keithc-ca keithc-ca commented Jun 15, 2018

Fixes Java 9 portion of eclipse-openj9/openj9#1919.

@keithc-ca keithc-ca requested a review from pshipton June 15, 2018 17:12
@pshipton
Copy link
Member

jenkins compile all

@pshipton
Copy link
Member

jenkins compile win

@pshipton
Copy link
Member

pshipton commented Jun 15, 2018

Not sure why Windows is failing, its failed twice with

17:09:08 * For target buildtools_corba_tools_classes__the.BUILD_TOOLS_CORBA_batch:
17:09:08 [stderr] java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: com/sun/tools/javac/util/RichDiagnosticFormatter$RichConfiguration$RichFormatterFeature
17:09:08 [stderr] 	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
17:09:08 [stderr] 	at java.util.concurrent.FutureTask.get(FutureTask.java:192)
17:09:08 [stderr] 	at com.sun.tools.sjavac.comp.PooledSjavac.compile(PooledSjavac.java:64)
17:09:08 [stderr] 	at com.sun.tools.sjavac.server.IdleResetSjavac.compile(IdleResetSjavac.java:70)
17:09:08 [stderr] 	at com.sun.tools.sjavac.server.RequestHandler.run(RequestHandler.java:104)
17:09:08 [stderr] Caused by: java.lang.NoClassDefFoundError: com/sun/tools/javac/util/RichDiagnosticFormatter$RichConfiguration$RichFormatterFeature
17:09:08 [stderr] 	at com.sun.tools.javac.util.RichDiagnosticFormatter$RichConfiguration.<init>(RichDiagnosticFormatter.java:643)
17:09:08 [stderr] 	at com.sun.tools.javac.util.RichDiagnosticFormatter.<init>(RichDiagnosticFormatter.java:104)
17:09:08 [stderr] 	at com.sun.tools.javac.util.RichDiagnosticFormatter.instance(RichDiagnosticFormatter.java:92)
17:09:08 [stderr] 	at com.sun.tools.javac.main.JavaCompiler.<init>(JavaCompiler.java:457)
17:09:08 [stderr] 	at com.sun.tools.javac.main.JavaCompiler.instance(JavaCompiler.java:112)

I'd like to think the problem is unrelated to this change, however the nightly builds [1] are working fine. I think I'll deliver the change assuming its a problem with the PR build (which has never worked) and can revert or fix if its a problem with this change. I also note the change is the same as for Java 8, 10, for which Windows compiles worked.

[1] https://ci.eclipse.org/openj9/view/Pipelines/job/Pipeline-Build-Test-JDK9-win_x86-64_cmprssptrs/

@pshipton pshipton merged commit f8f07f1 into ibmruntimes:openj9 Jun 15, 2018
@keithc-ca keithc-ca deleted the tools branch June 16, 2018 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants