Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce lock contention in Thread.getAndClearInterrupt #877

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

babsingh
Copy link
Member

@babsingh babsingh commented Nov 6, 2024

Lock contention in Thread.getAndClearInterrupt is reduced by
acquiring the lock only when the value of the Thread.interrupted
field is true.

Related: eclipse-openj9/openj9#20414

Lock contention in Thread.getAndClearInterrupt is reduced by
acquiring the lock only when the value of the Thread.interrupted
field is true.

Related: eclipse-openj9/openj9#20414

Signed-off-by: Babneet Singh <[email protected]>
@tajila
Copy link
Member

tajila commented Nov 6, 2024

jenkins test sanity alinux64 jdknext

@babsingh
Copy link
Member Author

babsingh commented Nov 7, 2024

Two undocumented failures are seen (see below for more details). I don't feel that these are caused due to this PR. These failures are seen probably because the JDK-next repo is unstable.

10:05:43  STDOUT:
10:05:43  test TestMappedHandshake.testHandshake(): failure
10:05:43  java.lang.AssertionError: expected [true] but found [false]
10:05:43  	at org.testng.Assert.fail(Assert.java:99)
10:05:43  	at org.testng.Assert.failNotEquals(Assert.java:1037)
10:05:43  	at org.testng.Assert.assertTrue(Assert.java:45)
10:05:43  	at org.testng.Assert.assertTrue(Assert.java:55)
10:05:43  	at TestMappedHandshake.testHandshake(TestMappedHandshake.java:90)
09:43:14  test KDFDelayedProviderSyncTest.testDerive(): failure
09:43:14  org.testng.internal.thread.ThreadTimeoutException: Method KDFDelayedProviderSyncTest.testDerive() didn't finish within the time-out 150
09:43:14  	at org.testng.internal.MethodInvocationHelper.invokeWithTimeoutWithNoExecutor(MethodInvocationHelper.java:322)
09:43:14  	at org.testng.internal.MethodInvocationHelper.invokeWithTimeout(MethodInvocationHelper.java:280)
09:43:14  	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:605)
09:43:14  	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
09:43:14  	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
09:43:14  	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
09:43:14  	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
09:43:14  	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
09:43:14  	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
09:43:14  	at org.testng.internal.thread.ThreadUtil.lambda$execute$0(ThreadUtil.java:66)
09:43:14  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:328)
09:43:14  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
09:43:14  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
09:43:14  	at java.base/java.lang.Thread.run(Thread.java:1588)

@tajila tajila merged commit b9db3ae into ibmruntimes:openj9 Nov 7, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants