Update jdk.test.lib.Platform to work with J9 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @keithc-ca @pshipton |
keithc-ca
requested changes
Jan 13, 2022
isServer() updated to return true if java.vm.name contains OpenJ9 or IBM. isDefaultCDSArchiveSupported() updated to return false if java.vm.name contains OpenJ9 or IBM since J9 does not support the default CDS archive. This is an updated fix for eclipse-openj9/openj9#14079. Related: ibmruntimes#390 Signed-off-by: Babneet Singh <[email protected]>
keithc-ca
approved these changes
Jan 13, 2022
|
jenkins test sanity.openjdk alinux64 jdknext |
|
There are too many failures. We don't have an exclude list for jdknext so all the tests that should be excluded are not. Pls port this change to jdk18 and I'll test it there. |
babsingh
added a commit
to babsingh/openj9-openjdk-jdk18
that referenced
this pull request
Jan 13, 2022
isServer() updated to return true if java.vm.name contains OpenJ9 or IBM. isDefaultCDSArchiveSupported() updated to return false if java.vm.name contains OpenJ9 or IBM since J9 does not support the default CDS archive. This is an updated fix for eclipse-openj9/openj9#14079. Related: ibmruntimes/openj9-openjdk-jdk#390 Backport: ibmruntimes/openj9-openjdk-jdk#391 Signed-off-by: Babneet Singh <[email protected]>
Created ibmruntimes/openj9-openjdk-jdk18#5. |
pshipton
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isServer()updated to returntrueifjava.vm.namecontainsOpenJ9orIBM.isDefaultCDSArchiveSupported()updated to returnfalseifjava.vm.namecontainsOpenJ9orIBMsince J9 does not support the default CDS archive.This is an updated fix for eclipse-openj9/openj9#14079.
Related: #390
Signed-off-by: Babneet Singh [email protected]