ceph-infra: move dashboard into a dedicated file

Instead of using multiple dashboard_enabled condition in the configure_firewall file we could just have the condition once and include the dedicated tasks list. Signed-off-by: Dimitri Savineau <[email protected]>
ibm-s390-cloud · Dec 18, 2019 · f4c261e · f4c261e
1 parent 4535985
commit f4c261e
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 57 deletions.
diff --git a/roles/ceph-infra/tasks/configure_firewall.yml b/roles/ceph-infra/tasks/configure_firewall.yml
@@ -173,65 +173,10 @@
       - iscsi_gw_group_name in group_names
     tags: firewall
 
-  - name: open node_exporter port
-    firewalld:
-      port: "{{ node_exporter_port }}/tcp"
-      zone: "{{ ceph_dashboard_firewall_zone }}"
-      permanent: true
-      immediate: true
-      state: enabled
+  - name: open dashboard ports
+    include_tasks: dashboard_firewall.yml
     when: dashboard_enabled | bool
 
-  - block:
-      - name: open dashboard port
-        firewalld:
-          port: "{{ dashboard_port }}/tcp"
-          zone: "{{ ceph_dashboard_firewall_zone }}"
-          permanent: true
-          immediate: true
-          state: enabled
-
-      - name: open mgr/prometheus port
-        firewalld:
-          port: "9283/tcp"
-          zone: "{{ ceph_dashboard_firewall_zone }}"
-          permanent: true
-          immediate: true
-          state: enabled
-    when:
-      - dashboard_enabled | bool
-      - mgr_group_name is defined
-      - (groups.get(mgr_group_name,[]) | length > 0 and mgr_group_name in group_names) or
-        (groups.get(mgr_group_name,[]) | length == 0 and mon_group_name in group_names)
-
-  - block:
-      - name: open grafana port
-        firewalld:
-          port: "{{ grafana_port }}/tcp"
-          zone: "{{ ceph_dashboard_firewall_zone }}"
-          permanent: true
-          immediate: true
-          state: enabled
-
-      - name: open prometheus port
-        firewalld:
-          port: "{{ prometheus_port }}/tcp"
-          zone: "{{ ceph_dashboard_firewall_zone }}"
-          permanent: true
-          immediate: true
-          state: enabled
-
-      - name: open alertmanager port
-        firewalld:
-          port: "{{ alertmanager_port }}/tcp"
-          zone: "{{ ceph_dashboard_firewall_zone }}"
-          permanent: true
-          immediate: true
-          state: enabled
-    when:
-      - dashboard_enabled | bool
-      - inventory_hostname in groups.get('grafana-server', [])
-
   - name: open haproxy ports
     firewalld:
       port: "{{ haproxy_frontend_port | default(80) }}/tcp"

diff --git a/roles/ceph-infra/tasks/dashboard_firewall.yml b/roles/ceph-infra/tasks/dashboard_firewall.yml
@@ -0,0 +1,55 @@
+---
+- name: open node_exporter port
+  firewalld:
+    port: "{{ node_exporter_port }}/tcp"
+    zone: "{{ ceph_dashboard_firewall_zone }}"
+    permanent: true
+    immediate: true
+    state: enabled
+
+- block:
+    - name: open dashboard port
+      firewalld:
+        port: "{{ dashboard_port }}/tcp"
+        zone: "{{ ceph_dashboard_firewall_zone }}"
+        permanent: true
+        immediate: true
+        state: enabled
+
+    - name: open mgr/prometheus port
+      firewalld:
+        port: "9283/tcp"
+        zone: "{{ ceph_dashboard_firewall_zone }}"
+        permanent: true
+        immediate: true
+        state: enabled
+  when:
+    - mgr_group_name is defined
+    - (groups.get(mgr_group_name,[]) | length > 0 and mgr_group_name in group_names) or
+      (groups.get(mgr_group_name,[]) | length == 0 and mon_group_name in group_names)
+
+- block:
+    - name: open grafana port
+      firewalld:
+        port: "{{ grafana_port }}/tcp"
+        zone: "{{ ceph_dashboard_firewall_zone }}"
+        permanent: true
+        immediate: true
+        state: enabled
+
+    - name: open prometheus port
+      firewalld:
+        port: "{{ prometheus_port }}/tcp"
+        zone: "{{ ceph_dashboard_firewall_zone }}"
+        permanent: true
+        immediate: true
+        state: enabled
+
+    - name: open alertmanager port
+      firewalld:
+        port: "{{ alertmanager_port }}/tcp"
+        zone: "{{ ceph_dashboard_firewall_zone }}"
+        permanent: true
+        immediate: true
+        state: enabled
+  when: inventory_hostname in groups.get('grafana-server', [])