Skip to content

Commit

Permalink
debian/uca: remove the handler notification
Browse files Browse the repository at this point in the history
The "update apt cache" in the ceph-handler role was never called and the
handler trigger after adding the uca repository doesn't exist at all.
Instead of using a handler for that we can just set the update_cache
parameter to true like the other apt_repository tasks.

Resolve merge conflict from cherry-picking this commit.

Signed-off-by: Dimitri Savineau <[email protected]>
  • Loading branch information
dsavineau authored and guits committed Mar 3, 2021
1 parent 42b571b commit 09d6706
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
3 changes: 1 addition & 2 deletions roles/ceph-common/tasks/installs/debian_uca_repository.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@
apt_repository:
repo: "deb {{ ceph_stable_repo_uca }} {{ ceph_stable_release_uca }} main"
state: present
update_cache: no
notify: update apt cache if a repo was added
update_cache: yes
7 changes: 0 additions & 7 deletions roles/ceph-handler/handlers/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@
- not rolling_update | bool
- not docker2podman | default(False) | bool
block:
- name: update apt cache
apt:
update-cache: yes
when: ansible_os_family == 'Debian'
register: result
until: result is succeeded

- name: mons handler
include_tasks: handler_mons.yml
when: mon_group_name in group_names
Expand Down

0 comments on commit 09d6706

Please sign in to comment.