Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chinese line break problem #62

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

lxwinspur
Copy link

When some buttons are described in Chinese, the shape of the button will change due to word wrapping.

Signed-off-by: George Liu [email protected]

@lxwinspur
Copy link
Author

@anoo1 @gtmills @rfrandse @mzipse
Could you please take a look at this patch, thanks.

@@ -46,7 +46,7 @@
</b-form-invalid-feedback>
</b-input-group>
</b-form-group>
<b-col align-self="baseline">
<b-col sm="2" align-self="baseline">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue still occurs with different screen sizes.
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nikhil-Ashoka
So, could you close the status bar on the right and check again?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, It works fine for the full screen in my system. However, If we are using a smaller screen, This issue is recurring.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What size screen did you use to test? Let's see if this problem is expected.

Copy link
Collaborator

@Nikhil-Ashoka Nikhil-Ashoka Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eg: Responsive: 770 * 1280 to 830 * 1280. This issue has occurred again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nikhil-Ashoka , Lemme check it again and fix it

When some buttons are described in Chinese, the shape of the button
will change due to word wrapping.

Signed-off-by: George Liu <[email protected]>
Copy link
Collaborator

@Nikhil-Ashoka Nikhil-Ashoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, Thanks!!!

@rfrandse rfrandse merged commit b28ad14 into ibm-openbmc:1030.ips Dec 6, 2022
rfrandse pushed a commit that referenced this pull request Jan 30, 2023
When some buttons are described in Chinese, the shape of the button
will change due to word wrapping.

Signed-off-by: George Liu <[email protected]>

Signed-off-by: George Liu <[email protected]>
rfrandse pushed a commit that referenced this pull request Jun 25, 2024
When some buttons are described in Chinese, the shape of the button
will change due to word wrapping.

Signed-off-by: George Liu <[email protected]>

Signed-off-by: George Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants