Qstatus #66
Merged
Qstatus #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parrobe
requested changes
Nov 20, 2018
| @@ -42,7 +42,7 @@ void setCCDTUrl(MQCNO *mqcno, PMQCHAR url, MQLONG length) { | |||
| mqcno->CCDTUrlOffset = 0; | |||
| mqcno->CCDTUrlPtr = NULL; | |||
| mqcno->CCDTUrlLength = length; | |||
| if (url != NULL) { | |||
| if (url != NULL && length > 0) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -252,6 +252,15 @@ func ReadPCFParameter(buf []byte) (*PCFParameter, int) { | |||
| case C.MQCFT_GROUP: | |||
| binary.Read(p, endian, &pcfParm.Parameter) | |||
| binary.Read(p, endian, &pcfParm.ParameterCount) | |||
|
|
|||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mqmetric/queue.go
Outdated
| package mqmetric | ||
|
|
||
| /* | ||
| Copyright (c) IBM Corporation 2016, 2018 |
There was a problem hiding this comment.
If this is a new file the copyright start date should be 2018 not 2016
parrobe
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure all items are complete before opening.
What
Add optional DIS QSTATUS metrics - which can be used on z/OS for minimal information
How
Add a queue.go following the pattern from channel.go, but had to modify names for uniqueness in package. Now use extended PCF command (_XR) format for z/OS compatibilty.
Testing
Used sample dashboards to collect data