Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check rc incase it is not no_more_msg #47

Merged
merged 1 commit into from
May 31, 2018

Conversation

parrobe
Copy link
Member

@parrobe parrobe commented May 30, 2018

Please ensure all items are complete before opening.

What

  • Modified return from getMessageWithHObj to return the mqreturn error for later processing.
  • Modified ProcessPublications() to verify error returned from getMessage() was MQRC_NO_MSG_AVAILABLE and if not return the error to the caller.

How

Added so that the metrics publication code would be able to detect other errors such as MQRC_Q_MGR_QUIESCING and so disconnect and stop the program from preventing the queue manager stopping.

Testing

Mnaual

Issues

Fixes #48

Copy link
Member

@sdmarshall79 sdmarshall79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@parrobe parrobe merged commit f15a287 into ibm-messaging:dev May 31, 2018
@parrobe parrobe deleted the errorhandle branch July 12, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants