Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time() method to MQMD type #159

Closed
wants to merge 1 commit into from

Conversation

ravellan
Copy link

Please ensure all items are complete before opening.

What

Add a Time method to MQMD that returns the put date/time as a native Go Time type
This is perhaps out of scope for this package and better suited for other packages which is fine.

How

PutDate and PutTime from the MD is parsed in the Time package to return a time.Time type
An error is returned if the MD is empty.

Testing

Test is added in package test suite.

Issues

N/A

@ibmmqmet
Copy link
Collaborator

Thanks for this idea. I don't think I want to accept the PR as-is, because there's actually a more general aspect to solve - the PutDate & Time fields can be set as well as read, and is also in the MQDLH structure.

So I think I'd like to take the concept here but do it slightly differently and cover all the options. Probably I'll add a single PutDateTime field into the structures as you can then choose in your app which to work with (can't delete the existing strings for compatibility).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants