refactored deoploy.sh to seprate the cluster creation layer #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NatarajBTI The Guardium Insights team would like to use MASOCP automation to create an OCP cluster to create a cluster we install our product on.
For that we have refactored the deploy.sh for AWS for now in this PR. We create a deploy-util.sh script that makes the OCP Creation part a function that we intend to call in our own repo.
I worked with @bkukoyi who worked with you earlier in the year to go over this. We would like to get this into master so we can always remain up to date with any OCP changes the masocp makes.
Can you please review and provide feedback on this.
In deploy_util.sh:
we moved the code into these two functions so we can call them from other scripts:
IAM_CREATE()
OCP_CREATE()