Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking in code changes.. #211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Checking in code changes.. #211

wants to merge 2 commits into from

Conversation

NatarajBTI
Copy link
Contributor

@shajeena @amitmangalvedkar - I have checked in all my code changes so far I have made. Please review the same.

shajeena
shajeena reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@shajeena shajeena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExocpProvisionedVPCId - Should be included in CFT to mention the existing ocp cluster

aws/master-cft/byol-existing-ocp/cft-mas-core.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExocpProvisionedVPCId - Should be included in CFT to mention the existing ocp cluster

shajeena
shajeena reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@shajeena shajeena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    log " $MANAGE_TABLESPACE: $$MANAGE_TABLESPACE"
    
    I know this is mistake from my code :) 
    replace with   log " MANAGE_TABLESPACE: $MANAGE_TABLESPACE"

shajeena
shajeena reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@shajeena shajeena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate if the DBProvisionedVPCId entered by the customer is valid or throw prevalidation error

shajeena
shajeena reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@shajeena shajeena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!Ref EBSVolumeType - this reference should be removed in exocp ?

@shajeena
Copy link
Contributor

@NatarajBTI - Maybe I missed it , template for creating UPI infrastructure is checked in under which folder ?

@NatarajBTI NatarajBTI mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajeena shajeena shajeena left review comments

@amitmangalvedkar amitmangalvedkar Awaiting requested review from amitmangalvedkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NatarajBTI @shajeena