Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Add Sanity tests for Manage #211

Merged
merged 66 commits into from
Nov 8, 2024
Merged

[minor] Add Sanity tests for Manage #211

merged 66 commits into from
Nov 8, 2024

Conversation

chiragcsatani
Copy link
Contributor

@chiragcsatani chiragcsatani commented Oct 22, 2024

MAXMF-551- Add Sanity Validation.

v1_secrets
v1_routes
manage_route
manage_host
getManageComponents
getClusterInfo
test_create_super_user_token
test_v3_create_user
test_v3_user_link_to_idp
test_v3_user_add_user_to_workspace
test_v3_user_application_permission
test_check_user_sync
test_generate_api_key_for_new_added_user
test_get_api_key_for_admin
test_add_new_user_to_admin_group
test_asset_crud_operation_using_new_added_user

MAXMF-551- Add Sanity Validation
moved tests to sanity test
@chiragcsatani chiragcsatani marked this pull request as ready for review October 22, 2024 18:36
Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes to allow the requirements.txt to be installed by adding a virtualenv.

The tests now run but fail with

E     File "/tmp/tests/tests.py", line 206
E       MAS_URL=https://{masUrl.spec.host}{masUrl.spec.path}
E                    ^
E   SyntaxError: invalid syntax

Chirag Satani added 21 commits October 23, 2024 19:51
Fix variable assignment and usage
fix minor error
removed fixture marker
minor fix
fix variables
fix error
Add logger info
fix errors
grant permission
fix error
removed unused resource call
fix secret
fix errors
fix secret
fix error
fix secret
Chirag Satani added 15 commits October 25, 2024 23:24
@whitfiea whitfiea self-requested a review October 28, 2024 09:11
Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests here currently create a user in MAS and sync it to Manage. This is a good start but we need to do more tests on Manage itself to ensure that basic functionality of Manage works. We can add a comment to say that demodata is needed and then we can run various API tests on some core Manage function to make sure it is working.

Comment on lines 93 to 95
- secrets
- routes
- suites
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rectified

Comment on lines 122 to 123
# MVI Verification tests need to be able to get/list nodes
# to check for ready GPU nodes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs updating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rectified

chiragcsatani and others added 8 commits November 6, 2024 01:43
updated as per feedback
Fix deleteuser and try decoded certs
try with disable warnings
added requirement
manage url for cluster
Added Manage tests for apikey and asset object
set cluster url
@whitfiea whitfiea changed the title [minor] MAXMF-551 [minor] Add Sanity tests for Manage Nov 8, 2024
@whitfiea whitfiea merged commit b644122 into main Nov 8, 2024
2 checks passed
@whitfiea whitfiea deleted the MAXMF-551 branch November 8, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants