Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Add junitreporter sub-chart for reporting sync to devopsdb #201

Merged
merged 51 commits into from
Sep 27, 2024

Conversation

whitfiea
Copy link
Contributor

@whitfiea whitfiea commented Sep 27, 2024

Adds a new sub-chart which is included in each argo app/helm chart we have. This new sub-chart called junitreporter has a presync and postsync job. The presync job will call the register-start.py script and create a configmap (if it doesn't exist) with the current time in. The register-start.py also has changes in the (ibm-mas/cli#1271) cli PR to accept the new ibm-mas-gitops productid. This will store that a sync job is started in the devops db.

The postsync of this new subchart runs when the main app chat completes its sync. This will call the save-junit-to-mongo script after creating a junit xml based test result (with just one testcase of sync). The configmap with the sync_start is used to determine the time taken. The configmap is then deleted by the post-sync job.

image- 2024-09-27 at 11 08 38

The reason the configmap is created by the job rather than as a resource is that when an app fails on sync it will re-sync and so the pre-sync is called again before the post-sync is called. This would reset the time in the configmap if it was a pure resource in the template.

Exmaple of a sync with the pre and post jobs:
image- 2024-09-24 at 09 08 21

The sub-chart will only be executed when the devops_mongo_uri is present.

WARNING: Although the sub-chart won't be used in envs that don't have devops_mongo_uri set, it will still need to template the subchart. This requires that the Vault Plugin being used in ArgoCD needs to run helm dependency update otherwise the helm template will error. The updated Vault Plugin config is present in the cli PR (ibm-mas/cli#1271). This is why this PR is marked as major as this needs to be in place regardless as to if the function will be used or not.

@whitfiea whitfiea marked this pull request as draft September 27, 2024 11:53
@whitfiea whitfiea merged commit 28f7f3a into main Sep 27, 2024
2 checks passed
@whitfiea whitfiea deleted the ajw-mascore3939 branch September 27, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants