[minor] Make install plan configurable for all subscriptions in gitops #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 23, 2024 12:08
sanjayprab
changed the title
whitfiea
requested changes
Sep 30, 2024
sanjayprab
changed the title
sanjayprab
changed the title
whitfiea
changed the title
whitfiea
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRE team want to control when updates happen to anything on a cluster, and control it at a fine-grain level.
To achieve this installPlanApproval on any subscription needs to be configurable.
Tested in test cluster to ensure that the defaults get set even if no varialbe is set in gitops repo.
https://jsw.ibm.com/browse/MASCORE-3901