[patch] Change hook delete policy to both HookSucceeded and BeforeHookCreation #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a hook completed we was leaving a number of resource around as these were not removed until the hook ran again. The delete policy was changed to hook succeeded.
In the case where the hook failed we still want to remove it as it would block further calls when the resource is a job as the max number of pods for the job would be reached. In this case we want to add the BeforeHookCreation policy so that is it removed before the hook is creation, but we want to keep the resources (pods of the jobs) around for debugging.