-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace configs appset with a helm template generator #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d are needed) for now
…f the scripts where necessary
(these have now all been replaced by the unified gitops-mas-config function)
…ls to the new gitops-mas-config function
IMPORTANT: revert this commit prior to merging into gitops branch
IMPORTANT: revert this commit prior to merging into gitops branch
(temporary measure until we get rid of the python yq that is overridden by the gitops functions)
…ig against the same file using a git branch as a lock
tomklapiscak
requested review from
durera,
andrercm,
sanjayprab,
terenceq and
whitfiea
as code owners
March 27, 2024 12:43
whitfiea
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forms part of the work for https://jsw.ibm.com/browse/MASCORE-2082 to replace the use of the configs ApplicationSet with a Helm template-based generator. This was necessary for a couple of reasons:
In order to implement the Helm-template-based Application generator, I was forced to merge all of our MAS config files (MongoCfg, SLSCfg, etc etc) into a single list in a single file in gitops-envs. (
ibm-mas-suite-configs.yaml
, example)This PR replaces all of the individual CLI functions for setting up MAS configs in their own files with a single function
gitops-mas-config
capable of maintaining the list in this single file. All configuration types (mongo
,sls
, etc) with any scope (system
,app
,ws
,wsapp
) can beupserted
orremoved
idempotently by this single script. All of the associated Tekton tasks have also been updated to use this new function.This PR also introduces the new
clone_and_lock_target_git_repo
andsave_and_unlock_target_git_repo
functions in gitops-utils that guard against merge conflicts that can happen when multiple instanves of the function for the same MAS instance are run in parallel. These functions are generic and will be suitable for use in other functions if we ever need to change them to update a single, shared config file in gitops-envs.Associated PRs:
Related Issues:
Testing: