Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized reset-domain for ant CLI and UCD Plugin. #99

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Parameterized reset-domain for ant CLI and UCD Plugin. #99

merged 1 commit into from
Mar 18, 2020

Conversation

tony-schndr
Copy link
Contributor

doRestore method in src/com/ibm/dcm/Soma.java hard coded reset-domain=true
in the generation of the SOMA command that is sent to DataPower. This change
allows that value to be passed to the dcm ant command line tool and via
the UCD plugin. In addition, the additional domains feature did not reset
the domains like the first domain was being reset, therefore I added the
reset-domain paramter to that line of code as well. The hard coded value
of reset-domain was true, so the default value for this is also true as to
not break existing users.

This change is to allow the user to decide wether or not to reset-domain
during a doRestore. Problems present themselves with exporting and importing
backups between equivalent devices (DataPowers behind a Load Balancer).
Domain backups do not export passwords, this is problematic when importing
the config to an equivalent domain on another DataPower as the reset-domain
causes the objects to be removed and reimported, causing the password in
the password map alias to be lost. As a result, the object that references
the password map alias will transition to a down state, potentially causing
a service outage.

doRestore method in src/com/ibm/dcm/Soma.java hard coded reset-domain=true
in the generation of the SOMA command that is sent to DataPower.  This change
allows that value to be passed to the dcm ant command line tool and via
the UCD plugin.  In addition, the additional domains feature did not reset
the domains like the first domain was being reset, therefore I added the
reset-domain paramter to that line of code as well.  The hard coded value
of reset-domain was true, so the default value for this is also true as to
not break existing users.

This change is to allow the user to decide wether or not to reset-domain
during a doRestore.  Problems present themselves with exporting and importing
backups between equivalent devices (DataPowers behind a Load Balancer).
Domain backups do not export passwords, this is problematic when importing
the config to an equivalent domain on another DataPower as the reset-domain
causes the objects to be removed and reimported, causing the password in
the password map alias to be lost.  As a result, the object that references
the password map alias will transition to a down state, potentially causing
a service outage.
Copy link
Collaborator

@nhmathis nhmathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to implement the proper upgrade procedure for bumping the version. Jyoti should be able to assist.

Looks goo to me otherwise!

@Jyoti-Prakash01
Copy link
Collaborator

Made required changes to upgrade, info xmls to master directly for this PR. Rest are already made here.

@Jyoti-Prakash01 Jyoti-Prakash01 merged commit 5dc8989 into ibm-datapower:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants