fix(background): set bing background before lazyload initialization #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoFelhz
previously requested changes
Jun 15, 2017
There was a problem hiding this comment.
We are using config_css.ejs to config theme.background.bgimg, and using lazyload with queue in import_js.ejs to load bing background, as bing background with aws cdn would cause terrible performance when loading.
koyabr
changed the title
|
@neoFelhz the lazyload idea is nice, I looked around in |
cubesky
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
In my chrome, the bing background fails to be loaded. After I swap the two js code blocks (1. set the
data-originalattr ofbody2. initialize lazyload), the bing picture is successfully fetched.I'm no expert in javascript, my best guess is that the order in which codes are written is important for
lsloader.runInlineScript().Verification steps
No verification steps.