Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache): localstorage cache js and css files #299

Merged
merged 5 commits into from
Apr 19, 2017
Merged

Conversation

EYHN
Copy link
Contributor

@EYHN EYHN commented Apr 17, 2017

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

If you don't do so, we might change your pull request's title and using squash to merge your changed.

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

demo: https://eyhn.github.io/hexo-test/
说不定会出现问题,请验证。


Verification steps

No verification steps.

@EYHN EYHN force-pushed the canary branch 4 times, most recently from 0b4e02f to eb06a71 Compare April 17, 2017 11:21
@EYHN
Copy link
Contributor Author

EYHN commented Apr 17, 2017

ok 我检查了一边 觉得没什么问题了

@neoFelhz neoFelhz requested review from cubesky and iblh April 17, 2017 14:33
@neoFelhz
Copy link
Collaborator

neoFelhz commented Apr 17, 2017

This chang was very important and experimental. I think we need to run a test on browserstack.
@cubesky @viosey

@cubesky
Copy link
Collaborator

cubesky commented Apr 17, 2017

Yes, We should test for this carefully.

@iblh
Copy link
Owner

iblh commented Apr 18, 2017

+1

@iblh iblh merged commit ec9eb11 into iblh:canary Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants