feat(progressbar): custom style functino and revert center-atom style #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pidupuis
requested changes
Jan 24, 2017
| # corner-indicator, fill-left, fill-left-nocolor, flat-top, loading-bar, macosx | ||
| # Or you can use your own style,just set the style value to "mycss", | ||
| # and put your own css style to source/css/pace/my.css |
There was a problem hiding this comment.
The barber-shop style being implemented in the barber-shop.css file, the big-counter style being implemented in big-counter.css file, and so on... the mycss style should be implemented in mycss.css file (not my.css), or in the other way, my.css file should implement the my style (not mycss).
That said, my is not a appropriate word. I would have called the style custom and its corresponding file custom.css. What do you think?
There was a problem hiding this comment.
OK, I will push further commit tonight
|
BTW, your commit messages do not follow the contributing rules :s 🙏 |
pidupuis
approved these changes
Jan 25, 2017
iblh
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
No description.
Verification steps
No verification steps.