-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(progressbar): custom style functino and revert center-atom style #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats to have fixed center-atom style ;)
# corner-indicator, fill-left, fill-left-nocolor, flat-top, loading-bar, macosx | ||
# Or you can use your own style,just set the style value to "mycss", | ||
# and put your own css style to source/css/pace/my.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The barber-shop
style being implemented in the barber-shop.css
file, the big-counter
style being implemented in big-counter.css
file, and so on... the mycss
style should be implemented in mycss.css
file (not my.css
), or in the other way, my.css
file should implement the my
style (not mycss
).
That said, my
is not a appropriate word. I would have called the style custom
and its corresponding file custom.css
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will push further commit tonight
BTW, your commit messages do not follow the contributing rules :s 🙏 |
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
No description.
Verification steps
No verification steps.