-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sidebar_footer_image): add sidebar footer image config #160
Conversation
Your pull request doesn't follow our guidelines. Please fix the following:
Click here for details. Thank you! 🙏 |
Thank you, the title and description now looks good! |
@@ -0,0 +1,9 @@ | |||
<% if(theme.img.footer_image) { %> | |||
<div id="footer-image"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I suggest you to put the
div
inside thefor
loop - Please change
#scheme-Paradox #upyun-logo
by#scheme-Paradox #footer-image
instyle.css
- Please test with multiple images to adapt the style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm...
In one div block it's horizontal so multiple pictures show well.
In multiple div block it's vertical and only show one picture. The next one have to be scroll to show.
I will try to fix it although I have no idea what is leading to such a strange behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try to change the div
for a span
and put them inside the loop
Good to go? |
Contributing rules
canary
. Then be sure to put thecanary
branch as the target for your pull request.Contributing rules
part from this descriptionWhat kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
Add footer image config.
Now users are able to add their own footer image.
#140 #141
to review
Verification steps