feat(sidebar_footer_image): add sidebar footer image config #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request doesn't follow our guidelines. Please fix the following:
Click here for details. Thank you! 🙏 |
simonsmh
changed the title
|
Thank you, the title and description now looks good! |
simonsmh
changed the title
pidupuis
requested changes
Jan 20, 2017
| @@ -0,0 +1,9 @@ | |||
| <% if(theme.img.footer_image) { %> | |||
| <div id="footer-image"> | |||
There was a problem hiding this comment.
- I suggest you to put the
divinside theforloop - Please change
#scheme-Paradox #upyun-logoby#scheme-Paradox #footer-imageinstyle.css - Please test with multiple images to adapt the style
There was a problem hiding this comment.
Hmmm...
In one div block it's horizontal so multiple pictures show well.
In multiple div block it's vertical and only show one picture. The next one have to be scroll to show.
I will try to fix it although I have no idea what is leading to such a strange behavior.
There was a problem hiding this comment.
Maybe try to change the div for a span and put them inside the loop
|
Good to go? |
pidupuis
approved these changes
Jan 22, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing rules
canary. Then be sure to put thecanarybranch as the target for your pull request.Contributing rulespart from this descriptionWhat kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
Add footer image config.
Now users are able to add their own footer image.
#140 #141
to review
Verification steps