Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(table-api): unify exception type for all backends to TableNotFound when a table does not exist #9695

Merged
merged 41 commits into from
Sep 16, 2024

chore: address review comments

c22979f
Select commit
Loading
Failed to load commit list.
Merged

refactor(table-api): unify exception type for all backends to TableNotFound when a table does not exist #9695

chore: address review comments
c22979f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Sep 15, 2024 in 0s

71.71% of diff hit (within 92.00% threshold of 95.06%)

View this Pull Request on Codecov

71.71% of diff hit (within 92.00% threshold of 95.06%)

Annotations

Check warning on line 178 in ibis/backends/bigquery/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/bigquery/__init__.py#L177-L178

Added lines #L177 - L178 were not covered by tests

Check warning on line 622 in ibis/backends/bigquery/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/bigquery/__init__.py#L622

Added line #L622 was not covered by tests

Check warning on line 626 in ibis/backends/bigquery/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/bigquery/__init__.py#L626

Added line #L626 was not covered by tests

Check warning on line 642 in ibis/backends/bigquery/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/bigquery/__init__.py#L639-L642

Added lines #L639 - L642 were not covered by tests

Check warning on line 876 in ibis/backends/bigquery/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/bigquery/__init__.py#L876

Added line #L876 was not covered by tests

Check warning on line 185 in ibis/backends/druid/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/druid/__init__.py#L185

Added line #L185 was not covered by tests

Check warning on line 244 in ibis/backends/exasol/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/exasol/__init__.py#L244

Added line #L244 was not covered by tests

Check warning on line 319 in ibis/backends/flink/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/flink/__init__.py#L319

Added line #L319 was not covered by tests

Check warning on line 557 in ibis/backends/pyspark/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/pyspark/__init__.py#L557

Added line #L557 was not covered by tests

Check warning on line 541 in ibis/backends/snowflake/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/snowflake/__init__.py#L541

Added line #L541 was not covered by tests

Check warning on line 553 in ibis/backends/snowflake/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/snowflake/__init__.py#L553

Added line #L553 was not covered by tests

Check warning on line 555 in ibis/backends/snowflake/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/snowflake/__init__.py#L555

Added line #L555 was not covered by tests

Check warning on line 558 in ibis/backends/snowflake/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/snowflake/__init__.py#L557-L558

Added lines #L557 - L558 were not covered by tests

Check warning on line 571 in ibis/backends/snowflake/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/snowflake/__init__.py#L570-L571

Added lines #L570 - L571 were not covered by tests