Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ibis connect duckdb when pass config #9204

Closed
wants to merge 2 commits into from

Conversation

SothanaV
Copy link

Description of changes

  • change pass config to duckdb if use ibis duckdb as a backend

Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud
Copy link
Member

cpcloud commented May 16, 2024

This PR does not have a description that matches what it does nor describes why it's necessary. The TOML change also doesn't have any stated motivation.

@cpcloud
Copy link
Member

cpcloud commented May 18, 2024

Closing this for now. We can't accept this PR as is:

  1. The description doesn't match the changes.
  2. Loading the httpfs extension is not something we should do at at startup.
  3. Executing each individual configuration SET as a separate query is also nothing something we should do at startup.

@cpcloud cpcloud closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants