Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(deps): remove dep caching and pipx usage in favor of plain pip #8956

Merged
merged 2 commits into from
Apr 13, 2024
Merged

ci(deps): remove dep caching and pipx usage in favor of plain pip #8956

merged 2 commits into from
Apr 13, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 13, 2024

Remove dependency caching and pipx usage to avoid CI hiccups from mismatching pipx python versions and target test python versions.

@cpcloud cpcloud added this to the 9.0 milestone Apr 13, 2024
@cpcloud cpcloud added ci Continuous Integration issues or PRs developer-tools Tools related to ibis development labels Apr 13, 2024
@cpcloud cpcloud changed the title chore: remove dep caching and pipx usage in favor of plain pip ci(deps): remove dep caching and pipx usage in favor of plain pip Apr 13, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Apr 13, 2024 •
edited
Loading

The use of pip install inside of poetry run (which was previously installed with a different version of Python) was causing wheels associated with a different version of Python to be installed than the one that was under test. See https://github.com/ibis-project/ibis/actions/runs/8668105648/job/23772495886?pr=8787 for an example.

Note the attempted install of a Python 3.10 torch wheel, while the Python version being tested is 3.11.

@cpcloud
Copy link
Member Author

cpcloud commented Apr 13, 2024

Merging, to get the other deps PR (#8787) over the finish line.

@cpcloud cpcloud merged commit 9f47670 into ibis-project:main Apr 13, 2024
83 checks passed
@cpcloud cpcloud deleted the remove-dep-caching-and-pipx branch April 13, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continuous Integration issues or PRs developer-tools Tools related to ibis development
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@cpcloud