Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update clickhouse/clickhouse-server docker tag to v24.3.2.23 #8885

Merged
merged 2 commits into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compose.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
clickhouse:
image: clickhouse/clickhouse-server:24.2.2.71-alpine
image: clickhouse/clickhouse-server:24.3.2.23-alpine
ports:
- 8123:8123 # http port
- 9000:9000 # native protocol port
Expand Down
3 changes: 2 additions & 1 deletion ibis/backends/clickhouse/tests/test_select.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from pytest import param

import ibis
from ibis.backends.tests.errors import ClickHouseDatabaseError

cc = pytest.importorskip("clickhouse_connect")

Expand Down Expand Up @@ -196,7 +197,7 @@ def test_non_equijoin(alltypes):
expr.compile()

# while execution should fail since clickhouse doesn't support non-equijoin
with pytest.raises(Exception, match="Unsupported JOIN ON conditions"):
with pytest.raises(ClickHouseDatabaseError, match="INVALID_JOIN_ON_EXPRESSION"):
expr.execute()


Expand Down
5 changes: 0 additions & 5 deletions ibis/backends/tests/test_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -796,11 +796,6 @@ def test_array_intersect(con, data):


@builtin_array
@pytest.mark.notimpl(
["clickhouse"],
raises=ClickHouseDatabaseError,
reason="ClickHouse won't accept dicts for struct type values",
)
@pytest.mark.notimpl(["postgres"], raises=PsycoPg2SyntaxError)
@pytest.mark.notimpl(["risingwave"], raises=PsycoPg2InternalError)
@pytest.mark.notimpl(["datafusion", "flink"], raises=com.OperationNotDefinedError)
Expand Down
23 changes: 7 additions & 16 deletions ibis/backends/tests/test_generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -1595,7 +1595,12 @@ def test_static_table_slice(backend, slc, expected_count_fn):
# negative stop
param(slice(-3, -2), lambda _: 1, id="[-3:-2]"),
# positive stop
param(slice(-4000, 7000), lambda _: 3700, id="[-4000:7000]"),
param(
slice(-4000, 7000),
lambda _: 3700,
id="[-4000:7000]",
marks=[pytest.mark.notyet("clickhouse", raises=ClickHouseDatabaseError)],
),
param(
slice(-3, 2),
lambda _: 0,
Expand All @@ -1606,6 +1611,7 @@ def test_static_table_slice(backend, slc, expected_count_fn):
raises=PyODBCProgrammingError,
reason="sqlglot generates code that requires > 0 fetch rows",
),
pytest.mark.notyet("clickhouse", raises=ClickHouseDatabaseError),
],
),
##################
Expand Down Expand Up @@ -1642,11 +1648,6 @@ def test_static_table_slice(backend, slc, expected_count_fn):
reason="backend doesn't support dynamic limit/offset",
)
@pytest.mark.notimpl(["exasol"], raises=ExaQueryError)
@pytest.mark.notyet(
["clickhouse"],
raises=ClickHouseDatabaseError,
reason="clickhouse doesn't support dynamic limit/offset",
)
@pytest.mark.notyet(["druid"], reason="druid doesn't support dynamic limit/offset")
@pytest.mark.notyet(["polars"], reason="polars doesn't support dynamic limit/offset")
@pytest.mark.notyet(
Expand Down Expand Up @@ -1697,11 +1698,6 @@ def test_dynamic_table_slice(backend, slc, expected_count_fn):
reason="backend doesn't support dynamic limit/offset",
)
@pytest.mark.notimpl(["exasol"], raises=ExaQueryError)
@pytest.mark.notyet(
["clickhouse"],
raises=ClickHouseDatabaseError,
reason="clickhouse doesn't support dynamic limit/offset",
)
@pytest.mark.notyet(["druid"], reason="druid doesn't support dynamic limit/offset")
@pytest.mark.notyet(["polars"], reason="polars doesn't support dynamic limit/offset")
@pytest.mark.notyet(
Expand Down Expand Up @@ -1975,11 +1971,6 @@ def test_select_sort_sort_deferred(backend, alltypes, df):
backend.assert_frame_equal(result, expected)


@pytest.mark.broken(
["clickhouse"],
raises=AssertionError,
reason="https://github.com/ClickHouse/ClickHouse/issues/61313",
)
@pytest.mark.notimpl(
["pandas", "dask"], raises=IndexError, reason="NaN isn't treated as NULL"
)
Expand Down
5 changes: 0 additions & 5 deletions ibis/backends/tests/test_window.py
Original file line number Diff line number Diff line change
Expand Up @@ -924,11 +924,6 @@ def test_ungrouped_unbounded_window(
@pytest.mark.notimpl(
["impala"], raises=ImpalaHiveServer2Error, reason="limited RANGE support"
)
@pytest.mark.notyet(
["clickhouse"],
reason="RANGE OFFSET frame for 'DB::ColumnNullable' ORDER BY column is not implemented",
raises=ClickHouseDatabaseError,
)
@pytest.mark.notyet(["mssql"], raises=PyODBCProgrammingError)
@pytest.mark.broken(
["mysql"],
Expand Down