Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(benchmarks): fix constructing large benchmark expression #8883

Merged
merged 1 commit into from
Apr 4, 2024
Merged

test(benchmarks): fix constructing large benchmark expression #8883

merged 1 commit into from
Apr 4, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Apr 3, 2024 •
edited
Loading

@kszucs kszucs requested a review from cpcloud April 3, 2024 19:35
@cpcloud
Copy link
Member

cpcloud commented Apr 3, 2024

We should try to figure out why this isn't failing in PRs, but we can do that in a follow-up.

kszucs
kszucs commented Apr 4, 2024
View reviewed changes
Copy link
Member Author

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kszucs kszucs merged commit bffaaa5 into ibis-project:main Apr 4, 2024
86 checks passed
@kszucs kszucs deleted the benchmark-fix branch April 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud Awaiting requested review from cpcloud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kszucs @cpcloud