Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): remove unnecessary methods used to implement negate() #8812

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Mar 28, 2024

The previous implementation contained multiple indirections which were hard to follow.

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cpcloud cpcloud added this to the 9.0 milestone Mar 28, 2024
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Mar 28, 2024
@cpcloud cpcloud merged commit f59f423 into ibis-project:main Mar 28, 2024
85 checks passed
@kszucs kszucs deleted the negate-api branch March 28, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants