feat(risingwave): add streaming DDLs, new #8781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeXiangWang
force-pushed
the
wkx/risingwave-streaming-features
branch
from
74e2038 to
e63c5cb
Compare
Given that Postgres and Risingwave don't support cross-catalog operations, we can use only the `database` kwarg to specify all the necessary bits here. I also tweaked the implementation of `overwrite` in `create_materialized_view` as I don't think it was doing the right thing.
gforsyth
reviewed
Mar 26, 2024
| @@ -175,6 +175,7 @@ def test_mutate_then_join_no_column_overlap(batting, awards_players): | |||
| @pytest.mark.notimpl(["druid"]) | |||
| @pytest.mark.notyet(["dask"], reason="dask doesn't support descending order by") | |||
| @pytest.mark.notyet(["flink"], reason="Flink doesn't support semi joins") | |||
| @pytest.mark.skip("risingwave") # TODO(Kexiang): Risingwave's bug, investigating | |||
There was a problem hiding this comment.
Suggested change
| @pytest.mark.skip("risingwave") # TODO(Kexiang): Risingwave's bug, investigating | |
| @pytest.mark.broken("risingwave") # TODO(Kexiang): Risingwave's bug, investigating |
whatever the reason, we want to get a signal when this test starts to pass, and with skip, that change will not be visible.
There was a problem hiding this comment.
The problem is that this case does not always fail. It actually can pass sometimes. But I haven't got time to explore under what conditions it will fail/pass. I think skip is more appropriate for now.
|
I'm going to close this in favor of #8239 (please correct/reopen if I'm interpreting this wrong) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In #8239 (A PR from company fork), I cannot allow maintainer to edit the PR. So I create this PR from my personal fork. All the changes in #8239 are included here.
Issues closed