Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datatypes): always quote sqlglot struct fields #8777

Merged
merged 8 commits into from
Mar 29, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 26, 2024

Fixes #8771.

@cpcloud cpcloud added this to the 9.0 milestone Mar 26, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis sql Backends that generate SQL labels Mar 26, 2024
@cpcloud cpcloud force-pushed the fix-struct-fields branch from c76b127 to 167b4e4 Compare March 26, 2024 10:18
@cpcloud cpcloud force-pushed the fix-struct-fields branch from c28405a to 4bd94a2 Compare March 26, 2024 10:35
@cpcloud
Copy link
Member Author

cpcloud commented Mar 26, 2024

Opened trinodb/trino#21264 for the trino issue discovered here.

@cpcloud cpcloud requested a review from kszucs March 26, 2024 12:30
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpcloud cpcloud merged commit 18bb91b into ibis-project:main Mar 29, 2024
81 checks passed
@cpcloud cpcloud deleted the fix-struct-fields branch March 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis sql Backends that generate SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: struct field names in DDLs should be quoted
2 participants