Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(util): remove unused get_logger utility function #8760

Merged
merged 2 commits into from
Mar 25, 2024
Merged

refactor(util): remove unused get_logger utility function #8760

merged 2 commits into from
Mar 25, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 25, 2024

Remove some dead code.

@cpcloud cpcloud added this to the 9.0 milestone Mar 25, 2024
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase developer-tools Tools related to ibis development labels Mar 25, 2024
@cpcloud cpcloud requested review from kszucs and gforsyth and removed request for kszucs March 25, 2024 12:17
@cpcloud cpcloud enabled auto-merge (squash) March 25, 2024 13:20
gforsyth
gforsyth approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah

@cpcloud cpcloud merged commit 0aceefc into ibis-project:main Mar 25, 2024
82 checks passed
@cpcloud cpcloud deleted the remove-dead-code branch March 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
developer-tools Tools related to ibis development refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @gforsyth