perf(sql): reduce the memory overhead of sqlglot compilation [WIP] #8596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
changed the title
kszucs
changed the title
|
After the merge of 461293b this isn't significantly improving the memory usage so closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced heavy memory usage during the reproduction of #8484, gigabytes of memory was used...
As turned out sqlglot expressions are aggressively deepcopied so we should minimize the amount of sqlglot expressions we hold references to.
Node.map()keeps the output for each ibis expression in a mapping during translation which is not ideal in this scenario.Luckily #7863 added a memory efficient
.map_clear()alternative which was primarily used in the pandas backend, but turns out to be useful here as well.Depends on #8592