Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(sql): prevent sqlglot from extensive deepcopying every time we create a sqlglot object #8592

Merged
merged 3 commits into from
Mar 13, 2024

chore(sql): don't copy sg.func() arguments

262ce8f
Select commit
Loading
Failed to load commit list.
Merged

perf(sql): prevent sqlglot from extensive deepcopying every time we create a sqlglot object #8592

chore(sql): don't copy sg.func() arguments
262ce8f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 12, 2024 in 1s

82.66% of diff hit (within 92.00% threshold of 92.55%)

View this Pull Request on Codecov

82.66% of diff hit (within 92.00% threshold of 92.55%)

Annotations

Check warning on line 15 in ibis/backends/bigquery/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/bigquery/compiler.py#L15 

Added line #L15 was not covered by tests

Check warning on line 710 in ibis/backends/bigquery/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/bigquery/compiler.py#L710 

Added line #L710 was not covered by tests

Check warning on line 713 in ibis/backends/bigquery/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/bigquery/compiler.py#L713 

Added line #L713 was not covered by tests

Check warning on line 11 in ibis/backends/flink/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/flink/compiler.py#L11 

Added line #L11 was not covered by tests

Check warning on line 470 in ibis/backends/flink/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/flink/compiler.py#L470 

Added line #L470 was not covered by tests

Check warning on line 191 in ibis/backends/mssql/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/mssql/compiler.py#L191 

Added line #L191 was not covered by tests

Check warning on line 110 in ibis/backends/sql/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/sql/__init__.py#L110 

Added line #L110 was not covered by tests

Check warning on line 138 in ibis/backends/sql/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/sql/compiler.py#L138 

Added line #L138 was not covered by tests

Check warning on line 1205 in ibis/backends/sql/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/sql/compiler.py#L1205 

Added line #L1205 was not covered by tests

Check warning on line 1207 in ibis/backends/sql/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/sql/compiler.py#L1207 

Added line #L1207 was not covered by tests

Check warning on line 1215 in ibis/backends/sql/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/sql/compiler.py#L1215 

Added line #L1215 was not covered by tests

Check warning on line 1217 in ibis/backends/sql/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/sql/compiler.py#L1217 

Added line #L1217 was not covered by tests

Check warning on line 1284 in ibis/backends/sql/compiler.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

ibis/backends/sql/compiler.py#L1284 

Added line #L1284 was not covered by tests
View more details on Codecov