Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: failing cotangent test #8571

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Mar 6, 2024

This fixes a test that was failing for bigquery (due to a divide-by-0 error). By adjusting the input data to not trigger this issue (what cot(0) does varies by backend) we can also remove all the other failure markers from the test.

@jcrist jcrist added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Mar 6, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Mar 6, 2024
@cpcloud cpcloud added this to the 9.0 milestone Mar 6, 2024
@cpcloud cpcloud added ci Continuous Integration issues or PRs tests Issues or PRs related to tests labels Mar 6, 2024
@cpcloud cpcloud merged commit e97d0d3 into ibis-project:main Mar 6, 2024
83 checks passed
@jcrist jcrist deleted the fix-cotangent-test branch March 6, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants