-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update contributing docs and env for m1/m2 devs #8495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibis-docs-bot
bot
removed
the
docs-preview
Add this label to trigger a docs preview
label
Feb 28, 2024
cpcloud
requested changes
Feb 29, 2024
ncclementi
force-pushed
the
docs-arm64
branch
3 times, most recently
from
March 1, 2024 00:37
71de6a5
to
7b2e470
Compare
chloeh13q
reviewed
Mar 1, 2024
chloeh13q
reviewed
Mar 1, 2024
chloeh13q
reviewed
Mar 1, 2024
This PR includes - Update to the arm64 enviornments to include quarto via conda-forge since now it's available. - Update to docs to contributing guidelines and testing, including a doc on how to setup colima.
Thanks @chloeh13q and @cpcloud for your review, I think I cover everything requested/suggested in the comments. |
ncclementi
force-pushed
the
docs-arm64
branch
2 times, most recently
from
March 1, 2024 14:28
0e12dc8
to
98e0261
Compare
cpcloud
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
Closes: #8372