Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resurrect SupportsSchema type; clean up unused ignored imports #8421

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 22, 2024

Bring back SupportsSchema

@cpcloud cpcloud added this to the 9.0 milestone Feb 22, 2024
@cpcloud cpcloud added the docs Documentation related issues or PRs label Feb 22, 2024
@cpcloud cpcloud force-pushed the bring-back-schema-type branch from 913992b to 61ef8a4 Compare February 22, 2024 13:34
Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud changed the title bring back schema type chore: resurrect SupportsSchema type; clean up unused ignored imports Feb 22, 2024
@cpcloud cpcloud force-pushed the bring-back-schema-type branch from 61ef8a4 to 678958f Compare February 22, 2024 14:08
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections -- was there a particular issue that prompted this?

@cpcloud
Copy link
Member Author

cpcloud commented Feb 22, 2024

Cleaning up some of the documentation build warnings discovered during Algolia inception.

@cpcloud
Copy link
Member Author

cpcloud commented Feb 22, 2024

Just to put a finer point on it: we're using SupportsSchema as a type annotation for some APIs' input parameters and quartodoc is generating qmd files that refer to the previously non-existent type.

@cpcloud cpcloud merged commit 21384c3 into ibis-project:main Feb 22, 2024
74 checks passed
@cpcloud cpcloud deleted the bring-back-schema-type branch February 22, 2024 16:25
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants