-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(comparison): wrap isnull equality check in parens #8366
Conversation
snowflake and bigquery are passing the new test:
|
ibis/backends/tests/test_generic.py
Outdated
|
||
@pytest.mark.broken(["mssql", "oracle"], reason="incorrect syntax") | ||
def test_isnull_equality(con, backend): | ||
ibis.set_backend(con) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be monkeypatched in to avoid altering the default backend for other tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARGH
I need to write a pre-commit check for this
We wrap arguments to a `sge.Equals` in parens if the inputs are themselves binary operations. There are other operations we will have to wrap -- for now I'm just adding `isNull` to the list, but I imagine this will grow, possibly on a backend-by-backend basis. I'm going to investigate the mssql and oracle failures but they are unrelated to this PR (they fail the added test with or without the parentheses)
43b16a6
to
da1c31f
Compare
) We wrap arguments to a sge.Equals in parens if the inputs are themselves binary operations. There are other operations we will have to wrap -- for now I'm just adding isNull to the list, but I imagine this will grow, possibly on a backend-by-backend basis. I'm going to investigate the mssql and oracle failures but they are unrelated to this PR (they fail the added test with or without the parentheses)
Description of changes
We wrap arguments to a
sge.Equals
in parens if the inputs arethemselves binary operations. There are other operations we will have
to wrap -- for now I'm just adding
isNull
to the list, but I imaginethis will grow, possibly on a backend-by-backend basis.
I'm going to investigate the mssql and oracle failures but they are
unrelated to this PR (they fail the added test with or without the parentheses)
Issues closed