Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sql): move dialects to always-importable location #8279

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 8, 2024

This PR consolidates our dialects into a single file (ibis/backends/base/sqlglot/dialects) to allow reuse without implicitly needing to import drivers or other backend-specific dependencies.

@cpcloud cpcloud added this to the 9.0 milestone Feb 8, 2024
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase sql Backends that generate SQL labels Feb 8, 2024
@cpcloud cpcloud requested a review from kszucs February 8, 2024 12:14
@cpcloud cpcloud force-pushed the consolidate-dialects branch 7 times, most recently from 2891c5d to 53ad3e2 Compare February 8, 2024 15:58
@cpcloud cpcloud force-pushed the consolidate-dialects branch from 53ad3e2 to b8d2b55 Compare February 8, 2024 15:59
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@cpcloud cpcloud enabled auto-merge (squash) February 8, 2024 16:34
@cpcloud cpcloud merged commit e75b229 into ibis-project:the-epic-split Feb 8, 2024
74 checks passed
@cpcloud cpcloud deleted the consolidate-dialects branch February 8, 2024 16:35
@cpcloud
Copy link
Member Author

cpcloud commented Feb 8, 2024

Gah, I keep forgetting we don't have CI blocking on the-epic-split. Enabling that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues or PRs related to refactoring the codebase sql Backends that generate SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants